sylvandb / gruvin9x

Automatically exported from code.google.com/p/gruvin9x
0 stars 0 forks source link

T-Trim switch #79

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What Version of the firmware are you running?

Find this by entering the global menu using [LEFT-LONG], then advance to
Menu 3 - VERSION. * Please record at least the SVN data, E.G: "trunk-r38"

*SVN:firmware-r1260
VERS:V1.2-gabo
DATE:2011-11-29
TIME:21:09:31

What steps will reproduce the problem?
1. go to model serup page 2/11
2. try to change T-Trim ON/Off and Linear/Exp
3. you can't change T-Trim values

What is the expected output? What do you see instead?
Set T-Trim and T-Expo 

What version of the product are you using? On what operating system?
r1285

Please provide any additional information below.
Version trunk/firmware before r1259 was working.
Latest branches/frsky version1285 is working OK.
I always use PCB=STD and SPKR builds

Original issue reported on code.google.com by gbir...@gmail.com on 29 Nov 2011 at 8:42

GoogleCodeExporter commented 8 years ago
Confirmed. Thank you.

Bertrand ... what's this about "Linear" in there. I've never seen that before 
and no one told me it was being introduced.

Original comment by gru...@gmail.com on 29 Nov 2011 at 9:50

GoogleCodeExporter commented 8 years ago
Error during the merge:

MENU("SETUP", menuTabModel, e_Model, (g_model.protocol ? 9 : 10), 
{0,sizeof(g_model.name)-1,3,0,0,0,1,6,2,1});

has wrongly been changed to:

MENU("SETUP", menuTabModel, e_Model, (g_model.protocol ? 10 : 11), 
{0,sizeof(g_model.name)-1,3,3,0,0,0,1,6,2,1});

Original comment by bson...@gmail.com on 30 Nov 2011 at 9:07

GoogleCodeExporter commented 8 years ago
Linear. No I didn't introduce it. It comes from er9x I think.

And the extra line that I introduced by mistake comes from my environment where 
I have 2 timers. Still needed to be finished && tested before introduction here.

Original comment by bson...@gmail.com on 30 Nov 2011 at 9:11

GoogleCodeExporter commented 8 years ago
OK Cool. 

So what on Earth does "linear" mean anyway? It doesn't seem to have any meaning 
to me -- and is not changeable to anything else anyway, right? So can we can 
lose it?

Original comment by gru...@gmail.com on 30 Nov 2011 at 10:28

GoogleCodeExporter commented 8 years ago
Feature introduced 15/08/2010 in er9x. There was one full line for this
parameter: "T-Expo" which had possible values "On" and "Off"
I changed to a single line for both throttle parameters. It should be
changeable, values can be "Linear" or "Exp" (see my last commit in trunk,
this problem should be solved now).

Anyhow I am ok to remove this feature which seems redundant to me with what
we have in DR/Expos screen. But I have to admit that I don't understand the
idea behind it (the expo fn is applied to v+RESX, instead of v otherwise
and at the end the RESX is substracted to the result). At the moment, I
think that the curves and the expos should do the job. Redundant feature.

If agreed, I will remove it with pleasure :)

Original comment by bson...@gmail.com on 1 Dec 2011 at 10:24

GoogleCodeExporter commented 8 years ago
Yes, I agree. The idea of applying exp to throttle is ludicrous to me. If 
people really want to do it for whatever crazy reason, then there are other 
places they can do so. I say let's lose this out of the menu entirely. Thanks. 
:-D

Original comment by gru...@gmail.com on 3 Dec 2011 at 9:24

GoogleCodeExporter commented 8 years ago
With pleasure I said :)

Original comment by bson...@gmail.com on 3 Dec 2011 at 9:27

GoogleCodeExporter commented 8 years ago
Removed.

Original comment by bson...@gmail.com on 3 Dec 2011 at 9:52