main_views.cpp telemetry views broken (trunk)

[GoogleCodeExporter]

FrSky HUB data isn't being displayed at all now (even with the make option set 
to YES) and the second data page (log file path when NO DATA) is showing the 
main screen stuff as well, when it shouldn't be.

What is the expected output? What do you see instead?

Please use labels and text to provide additional information.

To reproduce the 'second page wrong' part ...

Press [DOWN] to get to the main NO DATA (telemetry) view. Now press [RIGHT] 
once. You should see the "DATA CARD NOT PRESENT" message, or the current log 
file path, which you do -- but the rest of the screen that is showing should 
not be. The screen should be shown as a mostly blank page with the solid black 
title bard, just like when telemetry data is present. 

Thanks.

Original issue reported on code.google.com by gru...@gmail.com on 27 Jan 2012 at 5:50

[GoogleCodeExporter]

I think this all happened when the FRSKYHUB variable appeared in Makefile ... 
or maybe when the SDCARDLOG one appeared. Somewhere about that time.

I remember spending quite a lot of time getting frustrated while messing with 
the if (...) clauses to get this right. The tests ended up looking quite 
confusing, but I couldn't find an easier way.

Thanks again.

Original comment by gru...@gmail.com on 27 Jan 2012 at 5:53

[GoogleCodeExporter]

Ok. Will fix that.

Original comment by bson...@gmail.com on 27 Jan 2012 at 8:57

[GoogleCodeExporter]

In the TELEMETRY page (11/12), what did you choose for UsrProto? 

Original comment by bson...@gmail.com on 28 Jan 2012 at 11:33

[GoogleCodeExporter]

I didn't know there was such an option. Could it be moved to the top of the 
list? Being just a single item, I think it's best up there than "hidden" down 
the bottom.

Anyway, I just tried with UserProto set to "Hub" and was surprised to see 
absolutely no difference in behaviour. Still no Hub screens as there used to be 
in main views, which are still corrupted in the exact same way (log path 
appears over normal main view. No new title bar as expected.)

Obviously this isn't the case for you? But how could this be? Have I 
inadvertently broken the code during an svn auto-merge, perhaps? Could you try 
an svn up at your end and test again?

Original comment by gru...@gmail.com on 29 Jan 2012 at 9:43

[GoogleCodeExporter]

I have to admit that I only tested on simu. Let me try again.

Original comment by bson...@gmail.com on 29 Jan 2012 at 9:48

[GoogleCodeExporter]

When None: 2 screens, FrHub: a lot, WSHH: 3 screens

Original comment by bson...@gmail.com on 29 Jan 2012 at 10:04

[GoogleCodeExporter]

I think I see that only if there's actually data streaming in. I'm testing with 
no data present.

Original comment by gru...@gmail.com on 29 Jan 2012 at 10:24

[GoogleCodeExporter]

Ok. Understood. These screens are shown only if frsky data present. My opinion 
is that logs should not be in telemetry views, but somewhere near the 
statistics.

What would you like? I re-enable the screens even if no data present? I add a 
new menu when pressing [Down Long] in Main Views?

Original comment by bson...@gmail.com on 29 Jan 2012 at 11:06

[GoogleCodeExporter]

The logs are telemetry logs. Specifically, they log telemetry data. Therefore, 
it only makes sense to have them in the telemetry screen, I thought.

Yes please. I would very much prefer to have the screens always active -- 
regardless of whether data is streaming or not. I need to be able to see the 
last values received and decode and what not.

Thanks.

Original comment by gru...@gmail.com on 30 Jan 2012 at 4:00

[GoogleCodeExporter]

Original comment by bson...@gmail.com on 30 Jan 2012 at 8:11

• Changed state: Fixed

[GoogleCodeExporter]

Thank for the work. Nearly there. One more thing to finsih it.

When the WSHH is select as the User Protocol, we still see "GPS" as the page 
tiel, top right.

main_views line 211 says ...

      lcd_putsnAtt(17*FW-4, 0, PSTR(" MAIN  GPSOTHER") + 5 * (g_eeGeneral.view - e_telemetry) / ALTERNATE_VIEW - 5, 5, 0);

Perhaps there should be an addition if (..) surrounding this line or some 
other, better way of handling it? 

By the way, did you ever get the Fr-Sky air-pressure altimeter reading working 
properly? Remember -- my "satellite" issue? Alas, I've managed to somehow blow 
up my Fr-Sky hub, so I can't test anything.

Original comment by gru...@gmail.com on 31 Jan 2012 at 12:48

• Changed state: Started

[GoogleCodeExporter]

I will opt for a better way ... if it works.
And yes I have solved the other problem as well.
Will do the port in g9x trunk.

Original comment by bson...@gmail.com on 1 Feb 2012 at 8:30

[GoogleCodeExporter]

thanks :-D

Original comment by gru...@gmail.com on 2 Feb 2012 at 9:08

[GoogleCodeExporter]

I think that this issue is solved now.

Original comment by bson...@gmail.com on 23 Feb 2012 at 1:35

• Changed state: Fixed

[GoogleCodeExporter]

Yes it is. Thanks. The telemetry pages still need a bit of work (by me) to tidy 
up the log file stuff. Probably a separate page showing log file size and stuff 
instead of having the log file name splashed across every page. It's a typical 
Gruvin, very slow-moving work in progress. 

Original comment by gru...@gmail.com on 24 Feb 2012 at 12:17