search

sylvaticus / SPMLJ

Introduction to Scientific Programming and Machine Learning with Julia
https://sylvaticus.github.io/SPMLJ/stable
Creative Commons Attribution 4.0 International
48 stars 7 forks source link

I am going to send you some more typos #8

Open ghmorrison opened 5 months ago

ghmorrison commented 5 months ago

I would really appreciate additional directions or a link to the directions to run SPMLJ on my computer.

Do you want me to add adjustments to the code to my pull requests?

The current code dates back to Julia version 1.7 and I am using version 1.10.3. From: https://github.com/sylvaticus/SPMLJ/blob/main/lessonsSources/01_-_JULIA1_-_Basic_Julia_programming/0103_-_Predefined_types.jl

Examples

174 findall(x -> myComparitionWith1(x), [2,1,3,1]) 
408 mydict = Dict([k=>v for (k,v) in zip(k,v)])

Should if I am right be:

174 findall(myComparitionWith1, [2,1,3,1])
408 mydict = Dict( zip(k,v))
ghmorrison commented 5 months ago

I know I messed up. I should have tested it before I sent it. If you can send back both of them I will fix and test them.

The fix I know needs to be made is on line 459 newYearEvenDinner. The 'n' between "Eve" and "Dinner" needs to be removed to match my other changes.

sylvaticus commented 5 months ago

Sorry, I have participated at the "weekends without screens" so I read only now.

I'll look on all these later today....

ghmorrison commented 5 months ago

No worries. I have plenty of things to keep me busy.

I hope you had a great weekend George

On Mon, May 6, 2024 at 1:03 AM Antonello Lobianco @.***> wrote:

Sorry, I have participated at the "weekends without screens" so I read only now.

I'll look on all these later today....

— Reply to this email directly, view it on GitHub https://github.com/sylvaticus/SPMLJ/issues/8#issuecomment-2095250909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEU3WG4EPOXVKWKITL445DDZA4MKJAVCNFSM6AAAAABHHDIOCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVGI2TAOJQHE . You are receiving this because you authored the thread.Message ID: @.***>

sylvaticus commented 5 months ago

Hello, a few comments:

  1. It doesn't matter if you are on Julia 1.10. Julia (and its packages) follow "Semantic Version" style versioning, you can read the details here, but in short, everything that runs on JuliaOrPackage 1.x.y is guaranteed to run until 2.0.0 (excluded) (the opposite is not true). So If you are in Julia 1.10, no issues, the code, at least for the Julia Base itself, should work with no issues. To run the code locally on your computer, just clone the repository, or even better, first fork it on your GitHub and then clone your own fork. If you want to run also che quizzes locally, you need to build the documentation locally. Normally people don't need to do that, as they can answer the quizzes directly online, but if you need it locally, you just need to execute the code in makedoc.jl. The deploy section will not be executed, but you will find the compiled documentation, quizzes included, as HTML pages on the buildedDoc folder

  2. The findall and mydict examples that you highlight, work in both ways (the way in the course and the way you wrote them above). The versions as they are written now are just a bit more verbose, but feel free to use the shortened versions if you prefer

  3. I don't understand the newYearEvenDinner issue. The only pull request I had from you (that I have accepted and pushed) doesn't involve that variable. Currently, as it stands in the course, that variable is used 5 times in a consistent manner (it is always newYearEvenDinner), so it is fine for me...