Peer to peer code review

sylvester-wamaya / portfolio-website

A portfolio website that provides a brief profile description about me and showcase a sample of exceptional projects I have developed. A user can still contact me through the website platform. Developed using Javascript.

https://sylvester-wamaya.github.io/portfolio-website/

MIT License

6 stars 2 forks source link

Peer to peer code review #12

Open Braingenius2 opened 1 year ago

Braingenius2 commented 1 year ago

👋 Hello Wamaya

[ ] Your mobile menu works almost perfect but the menu seems to disappear whenever you click on it in the desktop version. You could try using different lists in the HTML for that or special media queries.
[ ] Just one more thing too, you could implement a backdrop filter property on the menu list whenever it's toggled to get the exact figma template design

By Fortune, Leiva, and Carlos 👍

sylvester-wamaya commented 1 year ago

I appreciate the feedback team, I will work on this before the end of today.

MasterLeiva commented 1 year ago

Hi @sylvester-wamaya

Your project looks great, but, as @Braingenius2 is saying you should fix the navigation bar.

[ ] I suggest you add a media query for the navigation bar to display it once it's big enough and also remember to style it so it looks like the Figma design.

sylvester-wamaya commented 1 year ago

Yes, great idea and observation. I'm on it right away.