sylviaokt / pe

0 stars 0 forks source link

edelete - error message does not match the error #10

Open sylviaokt opened 3 years ago

sylviaokt commented 3 years ago

When the index provided is 0, the error returned is Invalid command format, when it should be None of the indexes provided are valid as it is stated in the UG that INDEX is a positive integer, including 0.

image.png

image.png

nus-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Eedit - error message does not match the error

When the index provided is 0, the error returned is Invalid command format, when it should be The event index provided is invalid as it is stated in the UG that INDEX is a positive integer, including 0.

image.png

image.png


[original: nus-cs2103-AY2021S2/pe-interim#2508] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

0 is not a positive integer, the inclusive refers to the max integer value 2,147,483,647 and hence 0 is not an index, so the error is correct.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Under the BIRTHDAY parameter section, it is specified that year must be a positive integer between 0001 and 9999. The same terms positive integer and between was used here, however it started with 0001 and not 0000. On the other hand, the INDEX parameter mentioned in the bug report started off with 0. If the positive integer does not include 0, why did the UG not state clearly that it was between 1 and..., and used 0 instead? The inconsistency in documentation made me believe that there is a bug and that the error message should show The event index provided is invalid.

image.png


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]