search

sylviaokt / pe

0 stars 0 forks source link

Add command - duplicate person #2

Open sylviaokt opened 3 years ago

sylviaokt commented 3 years ago

For the add command, it is possible to add two contacts with the exact same phone, email and address and name (case-insensitive). image.png

nus-pe-bot commented 3 years ago

Team's Response

We do not believe that this is a bug because our Person entity is not linked or bound to any other entities that will result in an error arising from duplicates.

Currently, our Person entity is simply a display of information and thus adding duplicates will not affect the usage of the application. This is similar to how in most real life phone contact books allow duplicate contacts with no issues.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that this is a bug. The group's point about how most real life phone contact books allow duplicate contacts with no issues does not really hold here because adding a contact with the same name (case-sensitive) is actually not allowed in this application. If the application does not allow contacts of the same name (case-sensitive), why does it allow contacts of the same name (case-insensitive) to be added? There is no explanation for that anywhere in the UG or DG as well. Users might add a duplicate contact by accident as there is no warning or error messages to warn the user that such a contact already exists in the application. Furthermore, in the case where the user update a contact's information, and did not update the other duplicate contact, after a while when the user attempts to retrieve the contact information, the user might be confused as to which contact holds the most updated information. Hence, there should be a preventive mechanism to prevent users from entering a duplicate contact, and hence reduce confusion.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Severity should be Medium as this feature flaw poses occasional inconvenience to the users when they accidentally add a duplicate contact and the scenario mentioned above happens.