search

sylviaokt / pe

0 stars 0 forks source link

Eadd - case insensitive name #4

Open sylviaokt opened 3 years ago

sylviaokt commented 3 years ago

The command eadd allows the user to add in duplicate events (#9 and #10) with the same name (case insensitive), date and remark without any warning. This function might lead to users accidentally entering an duplicate event, causing unnecessary confusion.

image.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add command - duplicate person

For the add command, it is possible to add two contacts with the exact same phone, email and address and name (case-insensitive). image.png

[original: nus-cs2103-AY2021S2/pe-interim#2506] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We do not believe that this is a bug because our Person entity is not linked or bound to any other entities that will result in an error arising from duplicates.

Currently, our Person entity is simply a display of information and thus adding duplicates will not affect the usage of the application. This is similar to how in most real life phone contact books allow duplicate contacts with no issues.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Duplicate events are different from duplicate contacts as they serve different purposes.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that this is a feature flaw. The group's point about how most real life phone contact books allow duplicate contacts with no issues does not really hold here because adding an event with the same name (case-sensitive) is actually not allowed in this application. If the application does not allow events of the same name (case-sensitive), why does it allow events of the same name (case-insensitive) to be added? There is no explanation for that anywhere in the UG or DG as well. Adding a duplicate event might cause confusion to the users as they might accidentally add in duplicate events. For example, users can mark an event as done and delete it. However, the presence of another duplicate event would make the users question themselves if the event is done or not.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Severity should be Medium because it causes inconvenience for the users, due to the lack of preventive measures to ensure that users do not key in duplicate events accidentally.