Error while downloading multiple Spotify albums

zcraber commented 1 year ago

Type: Error

Title:

Internal error occurred!

Content:

{}

TypeError: Cannot read properties of null (reading 'width') at C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\util\downloadManager.js:291:99 at Array.sort () at createDownloadObject (C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\util\downloadManager.js:291:83) at C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\util\downloadManager.js:490:55 at Array.map () at C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\util\downloadManager.js:490:46 at new Promise () at Object.createDownload (C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\util\downloadManager.js:484:74) at Object.func (C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\core\ipc\queue\download.js:7:76) at IpcMainImpl. (C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\core\ipcHandler.js:26:25)

(no stack)

Stack:

- at module.exports (C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\core\sendNotification.js:24:34)
- at module.exports (C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\util\errorHandler.js:8:48)
- at process.<anonymous> (C:\Users\zcraber's PC\AppData\Local\Programs\ezytdl\resources\app.asar\index.js:20:125)
- at process.emit (node:events:513:28)
- at emit (node:internal/process/promises:149:20)
- at processPromiseRejections (node:internal/process/promises:294:27)
- at process.processTicksAndRejections (node:internal/process/task_queues:96:32)

Below this line, please describe what caused this error.

Added several Spotify album links and clicked download.

sylviiu commented 1 year ago

~~I KNEW I OVERLOOKED SOMETHING~~ this was not something i added recently, nvm lol

i'll try to fix this before next nightly 😅

sylviiu commented 1 year ago

Can you provide the album links you used? Testing it with some albums on my side worked fine, I can only assume it's an edge case

zcraber commented 1 year ago

Can you provide the album links you used?

Sure. I could reproduce this issue every time with any Spotify album or playlist. Are there any additional logs or info I should provide to get this issue sorted?

sylviiu commented 1 year ago

that's... strange?

I don't think I've put any useful logs to help troubleshoot that, so I'm not sure that'd be much help :(

The error is caused by malformed thumbnail objects; I do feel like the most recent commits I've pushed could possibly fix this issue? (before, the thumbnails never registered for the first playlist entries / entry of a batch URL query, that's been fixed -- see screenshot below)

I could try to push one more commit that may directly address this error, and have you try a test build?

zcraber commented 1 year ago

have you try a test build?

This is from the nightly build 2.5.0-dev.122.

sylviiu commented 1 year ago

I created a workflow that builds the app (without releasing it) for testing.

Could you try to download, extract and run this test build artifact (compressed in a zip file, ~300mb) and see if the issue has been resolved? (or if there is a new error from said fix?)

...sorry for all of this haha

zcraber commented 1 year ago

No worries! You've developed such a wonderful tool nevertheless.

It did resolve that error, but it showed another error failed to download. Should I provide the entire error? Because it mentioned I shouldn't create an issue for that error.

sylviiu commented 1 year ago

Because it mentioned I shouldn't create an issue for that error.

hmm.. i believe this is standard error output for yt-dlp, did the error appear when you tried to download? or was it when you were gathering the info from the playlists?

zcraber commented 1 year ago

It appeared when I tried to download.

sylviiu commented 1 year ago

yeah, likely an issue with the website (could be region locking? that's where i run into most issues)

~~that's unfortunately something i cannot fix :(~~ it might be possible to fix when searching for a youtube equivalent of a spotify track, but i'm not sure how to determine if something is actually viewable... i'd have to look into it

as of now, i do believe this issue has been resolved! :D

should appear in next nightly within 3 hours, as per usual :)

zcraber commented 1 year ago

it might be possible to fix when searching for a youtube equivalent of a spotify track, but i'm not sure how to determine if something is actually viewable... i'd have to look into it

I noticed that the failed to download error occurs only when trying to download multiple albums at once. They can be downloaded individually if that helps.

sylviiu commented 1 year ago

That's strange... does the error show the URL it tried to download by any chance?

On July 20, 2023 2:55:01 PM CDT, Joseph @.***> wrote:

it might be possible to fix when searching for a youtube equivalent of a spotify track, but i'm not sure how to determine if something is actually viewable... i'd have to look into it

I noticed that the failed to download error occurs only when trying to download multiple albums at once. They can be downloaded individually if that helps.

-- Reply to this email directly or view it on GitHub: https://github.com/sylviiu/ezytdl/issues/20#issuecomment-1644515068 You are receiving this because you modified the open/close state.

Message ID: @.***>

zcraber commented 1 year ago

Yes, it showed error like this for all tracks:

yt-dlp failed to download https://open.spotify.com/track/3KtXPo010piTIrBQDZFInz [1]

sylviiu commented 1 year ago

...aaand this issue opens back up 😅 it should not be trying to download the original Spotify link

I'll look into it a little bit later. I have a feeling I know what's happening

sylviiu commented 1 year ago

THIS TIME I think it's fixed. I made sure to thoroughly test it, I'm pretty sure everything works okay now.

https://github.com/sylviiu/ezytdl/assets/95180094/649da76d-1212-49a5-9377-e51888b0d412

only a minor amount of hair was pulled throughout the debugging of this issue i swear

sylviiu / ezytdl