search

symbench / electric-circuits

Electric Circuits Domain for webGME
https://webgme.symbench.org
Apache License 2.0
12 stars 3 forks source link

RecommendNextComponents Should Return MetaTypes Rather than PySpice Types. #111

Closed umesh-timalsina closed 3 years ago

umesh-timalsina commented 3 years ago

It might be nice to map recommend results of recommend next components to MetaType when running the plugin rather than PySpice Types.

umesh-timalsina commented 3 years ago

This will be helpful for displaying recommendations in the ElectricCircuitsEditor Visualizer.

brollb commented 3 years ago

I think this sounds good but I would add this as a post-processing step after the individual model is used (similar to how sorting is currently handled).

umesh-timalsina commented 3 years ago

Yeah. This step should be agnostic of the model used. Also, some components (Like DCTransmissionLine) might be missing in the metamodel, which would be a nice check to have.