search

symbench / electric-circuits

Electric Circuits Domain for webGME
https://webgme.symbench.org
Apache License 2.0
12 stars 3 forks source link

Add "Smart" component recommender to ElectricCircuits Editor. Closes #103 #114

Closed umesh-timalsina closed 3 years ago

brollb commented 3 years ago

Nice. Can you post a screenshot? I would like to see it but am currently on my phone :)

umesh-timalsina commented 3 years ago

@brollb I have a mp4 here. LMK if that works (Pardon the unnecessary frames).

https://user-images.githubusercontent.com/11476842/111396076-54222780-868c-11eb-8822-a9260e003d32.mp4

umesh-timalsina commented 3 years ago

@brollb. What do you think of the video so far? We can use some animation/scaling we discussed before to make it more fancy. Are there any redflags you see with a button based approach? I can see displaying a form for selection of available example models to use might make it more usable.

brollb commented 3 years ago

I think the video looks good for a first pass. There are a couple minor aesthetic things like the vertical spacing (the components seem closer to the top then the bottom) and the red background on the X is a little weird (I would probably just remove it and have the box close on unfocus/clicking outside of it).

As far as the model selection, it would be nice to make it configurable but I would try to avoid setting it each time the box opens. I would either opt for a config icon where you can set the model to use next to the button or an indicator next to the button where you can select the model to use. Maybe the config icon and then displaying it at the bottom of the opened component recommender would be the way to go.

umesh-timalsina commented 3 years ago

Here's an implementation I came up with for configuration. Its semi hard coded but works.

image

brollb commented 3 years ago

What if you made it the cog wheel icon that, when clicked, drops down a small form with the one entry (model/algorithm) for now?

Also, there is probably a better name for the recommended components. What if you call it "Component Toolbox" or something and then add a divider (like <hr>) and display all the components below it? The window will need to be scrollable but then we would be able to forgo the part browser all together.

umesh-timalsina commented 3 years ago

Rather than adding a separate graph as shown in this PR. #118 adds a component Browser. image.

As suggested here, I think a betterway would be to sort components in the component browser itself which works better for demo purposes.

umesh-timalsina commented 3 years ago

This now looks like the following: image image

umesh-timalsina commented 3 years ago

It might be nice to figure out what the failures would look like. Currently a simple alert ? Might be related to #82. The error messages are not informative enough to display in a custom HTML container.