symbench / electric-circuits

Electric Circuits Domain for webGME
https://webgme.symbench.org
Apache License 2.0
12 stars 3 forks source link

Display component links based on recommendation Plugin results. Closes #126 #132

Closed umesh-timalsina closed 3 years ago

umesh-timalsina commented 3 years ago

Now that the recommended components are added to the circuit graph based on variable opacity, I think a workflow for this addition should be like:

  1. Pass on a temporary node creation event to webGME, let the visualizer control create nodes and assign wires.
  2. If no recommendation is taken by the user, remove the created nodes/wires.
  3. If one of the recommendation is selected, remove the other two and let webGME handle the removal of nodes.
brollb commented 3 years ago

This will be nice to merge as it will make testing recommendation models (like https://github.com/symbench/electric-circuits/pull/120) easier. What is blocking it currently? Would it be possible to move the remaining tasks to a separate issue/PR?

umesh-timalsina commented 3 years ago

Sure. I will finish this up today. :)

umesh-timalsina commented 3 years ago

Currently getting SPICE nodes from the plugin instead of GME Pin ids:

"[
  [
    [
      {
        "type": "Voltage",
        "pins": [
          "N0007",
          "N0006"
        ]
      }
    ],
    0.5
  ],
  [
    [
      {
        "type": "Resistor",
        "pins": [
          "N0007",
          "N0006"
        ]
      }
    ],
    0.5
  ]
]"