Unwanted icons visible in buttons and fix incorrect argument order

satrun77 commented 9 months ago

Description

The workflow interface looks like the following

When applying workflow to a page. There is an error related to an incorrect argument for insertBefore

[Emergency] Uncaught TypeError: SilverStripe\Forms\FieldList::insertBefore(): Argument #2 ($item) must be of type SilverStripe\Forms\FormField, string given, called in /Users/mo/Sites/cms/vendor/silverstripe/framework/src/Forms/CompositeField.php on line 349

Manual testing steps

Add a workflow and select the default template
The next screen shows the issue 1
Go to a page
Apply workflow from settings tab
There is a PHP error about the argument

Pull request checklist

[x] The target branch is correct
- See picking the right version
[x] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[x] The commit messages follow our commit message guidelines
[x] The PR follows our contribution guidelines
[x] Code changes follow our coding conventions
[x] This change is covered with tests (or tests aren't necessary for this change)
[x] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[x] CI is green

GuySartorelli commented 9 months ago

Also please make sure there is an issue for each pull request (that was in the PR template, looks like you removed that section for some reason in your PR description). We track issues rather than pull requests, so it will be easier to make sure this contribution doesn't get lost and forgotten if we have an issue for it.

satrun77 commented 9 months ago

Also please make sure there is an issue for each pull request (that was in the PR template, looks like you removed that section for some reason in your PR description). We track issues rather than pull requests, so it will be easier to make sure this contribution doesn't get lost and forgotten if we have an issue for it.

It was accidental 🤣 thanks I will fix that

satrun77 commented 9 months ago

@GuySartorelli PR https://github.com/symbiote/silverstripe-advancedworkflow/pull/513

I will close this one and create another PR for https://github.com/symbiote/silverstripe-advancedworkflow/issues/515

symbiote / silverstripe-advancedworkflow