Move configs from local.conf.php to _ss_environment.php

symbiote / silverstripe-build

Phing build settings and tasks for the silverstripe-base project

BSD 3-Clause "New" or "Revised" License

0 stars 8 forks source link

Move configs from local.conf.php to _ss_environment.php #14

Closed silbinarywolf closed 6 years ago

silbinarywolf commented 7 years ago

Why? All define() constants done in _ss_environment.php are usable in caching layers or before building the various ConfigManifest files, etc.

By putting database, environment and log settings in this file, we can update our caching layers use these values and/or store cache configs there. (One centralized place for server configurations sounds like a good idea to me!)

Silverstripe versions? IIRC, _ss_environment.php only works 3.2+, but maybe its in 3.1+ and just not documented.

alexclifford commented 7 years ago

This would likely require a restructure to our mysite/_config.php templates but if it's doable the benefits sound fine? @nyeholt

nglasl commented 6 years ago

Closing this one since everything is now using .env for SS 4.