search

symbiote / silverstripe-build

Phing build settings and tasks for the silverstripe-base project
BSD 3-Clause "New" or "Revised" License
0 stars 8 forks source link

fix(Windows): Fix issue where git auto converting to LF causes patching issues on Git repos that use CRLF (ie. Lumberjack). Only affects Windows. #16

Closed silbinarywolf closed 7 years ago

silbinarywolf commented 7 years ago

fix(Windows): Fix issue where git auto converting to LF causes patching issues on Git repos that use CRLF (ie. Lumberjack). Only affects Windows.

silbinarywolf commented 7 years ago

This PR just needs to check for the existence of "dos2unix" before running and should be OK. This is an edge case so not sure if we want this code. Definitely need something to help catch weird line endings though to avoid weird cross-OS issues.

Or... everyone needs to just use VMs.

alexclifford commented 7 years ago

We've decided to put this one into the too hard basket (too many variables to go wrong) and try to stick to Linux VMs for development.