search

symbiote / silverstripe-gridfieldextensions

A collection of useful grid field components.
BSD 3-Clause "New" or "Revised" License
96 stars 125 forks source link

[SS 4.3] Input group markup is out, select field has border radius #269

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Versions:

The input group for the "add new multi class" component probably has incorrect markup structure. This could be different between Bootstrap 4 beta and stable (SS 4.0/1 and SS 4.2).

image

It shouldn't have border radius on the RHS of the select box

ScopeyNZ commented 6 years ago

This is related to chrome not allowing you to change the borders on selects any more (without losing the arrows) - A bootstrap update will fix this as they've done some magic with an svg for the arrow icon in a later version.

robbieaverill commented 6 years ago

Hmmm, the docs have a working example though: https://getbootstrap.com/docs/4.1/components/input-group/#custom-select

robbieaverill commented 6 years ago

Adding custom-select class to the select field fixes it

ScopeyNZ commented 6 years ago

Oh my mistake. I thought that wasn't available and did not realise it was controlled by an additional class (custom-select).

robbieaverill commented 6 years ago

My mistake, the inputs I'm looking at are part of the elemental module. If this issue occurs in the PHP GridField component, the solution is above