search

symbiote / silverstripe-queuedjobs

A module that provides interfaces for scheduling jobs for certain times.
BSD 3-Clause "New" or "Revised" License
57 stars 74 forks source link

Global state affecting some of the tests on CWP 2.0 #190

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Context: SS 4.1.1, CWP 2.0.0, queuedjobs 4.1.x-dev bf35e56a7af57d60e69efaf2db52bfd9d3d9d956

The CWP environment is affecting a couple of the queuedjobs unit tests.

$ php -d memory_limit=2G vendor/bin/phpunit --testsuite cwpsearch --filter QueuedJobsTest vendor/symbiote/silverstripe-queuedjobs/tests '' flush=1
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

......FF....                                                      12 / 12 (100%)

Time: 35.84 seconds, Memory: 278.50MB

There were 2 failures:

1) Symbiote\QueuedJobs\Tests\QueuedJobsTest::testStartJob
Failed asserting that false is true.

/Users/robbieaverill/dev/releases/release-cwp_cwp-recipe-kitchen-sink-2.0.0-rc4/vendor/symbiote/silverstripe-queuedjobs/tests/QueuedJobsTest.php:186
/Users/robbieaverill/dev/releases/release-cwp_cwp-recipe-kitchen-sink-2.0.0-rc4/vendor/phpunit/phpunit/phpunit:52

2) Symbiote\QueuedJobs\Tests\QueuedJobsTest::testImmediateQueuedJob
Failed asserting that 2 matches expected 0.

/Users/robbieaverill/dev/releases/release-cwp_cwp-recipe-kitchen-sink-2.0.0-rc4/vendor/symbiote/silverstripe-queuedjobs/tests/QueuedJobsTest.php:215
/Users/robbieaverill/dev/releases/release-cwp_cwp-recipe-kitchen-sink-2.0.0-rc4/vendor/phpunit/phpunit/phpunit:52

FAILURES!
Tests: 12, Assertions: 74, Failures: 2.

Ideally these would run without environmental impact

robbieaverill commented 6 years ago

Fix at #195