search

symbiote / silverstripe-queuedjobs

A module that provides interfaces for scheduling jobs for certain times.
BSD 3-Clause "New" or "Revised" License
57 stars 73 forks source link

MNT Ensure parent::__construct() is not passed the wrong param types #398

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

Issue https://github.com/silverstripeltd/product-issues/issues/676

The failures in recipe-kitchen-sink only showed up because a) we added staticpublishqueue to the sink, and it has this yml - https://github.com/silverstripe/silverstripe-staticpublishqueue/blob/6.0/_config/staticpublishqueue.yml#L24 which leads to this being called - https://github.com/silverstripe/silverstripe-staticpublishqueue/blob/6.0/src/Dev/StaticPublisherState.php#L21 b) the latest version of monolog now has strong typing, previously it was loosely typed - https://github.com/Seldaek/monolog/blob/main/src/Monolog/Handler/AbstractHandler.php#L36

GuySartorelli commented 1 year ago

Short version of the comment: We pass arguments in when instantiating a new one of these via Injector. The new constructor we've added here effectively says "Ignore the arguments, we don't want them, they're inconsistent with the parent constructor."