FIX Replace assignment with intended comparison

symbiote / silverstripe-queuedjobs

A module that provides interfaces for scheduling jobs for certain times.

BSD 3-Clause "New" or "Revised" License

57 stars 73 forks source link

FIX Replace assignment with intended comparison #421

Closed oddnoc closed 5 months ago

oddnoc commented 5 months ago

Expected behaviour

If E_DEPRECATED is defined and $errno is either E_DEPRECATED or E_USER_DEPRECATED, return from handleError().

Actual behaviour

If E_DEPRECATED is defined and $errno is any value, return from handleError(). This means that exceptions are never thrown by the method whenever E_DEPRECATED is defined.

GuySartorelli commented 5 months ago

Please also retarget this PR to the 5.1 branch so it can be released as a patch.

oddnoc commented 5 months ago

Will open a new PR