search

symbiote / silverstripe-seed

Symbiote Seed. A set of modules that form a solid foundation for SilverStripe website builds.
BSD 3-Clause "New" or "Revised" License
8 stars 7 forks source link

https://github.com/studiobonito/silverstripe-spamprotection-honeypot #31

Closed nglasl closed 7 years ago

nglasl commented 7 years ago

https://github.com/studiobonito/silverstripe-spamprotection-honeypot/blob/master/composer.json#L26

This module needs to support 3.5.

silbinarywolf commented 7 years ago

@nglasl Whats wrong with this PR? https://github.com/studiobonito/silverstripe-spamprotection-honeypot/pull/8/files

silbinarywolf commented 7 years ago

Actually just noticed, probably not ideal if it ends up pulling into a SS4 project. Will fiddle.

nglasl commented 7 years ago

Nothing, and it shouldn't cause it to pull down into a 4.0 project. This is more..

a) Why was this locked down to <3.3 to begin with? Perhaps there's something nasty in here that doesn't play with 3.5? Perhaps this was just how the dependency was done at the time, just because? b) This is pretty much an issue so long as that PR hasn't been merged.

silbinarywolf commented 7 years ago

Works as expected in 3.5.3.

nglasl commented 7 years ago

Closing this issue, since the PR has now been merged, and https://github.com/silverstripe-australia/silverstripe-ba-sis/commit/21b705c32c6f5073bf48d74957ce6312b8bd3744 introduces the support for 3.5.