Dashboard. Improve transaction previews

symbol / desktop-wallet

Desktop wallet for Symbol.

Apache License 2.0

77 stars 72 forks source link

Closed OlegMakarenko closed 3 years ago

OlegMakarenko commented 3 years ago

Display amount only for native mosaic
Show mosaic icon for non-native mosaic transfers
Show envelope icon if message included
Display custom aggregate types (ex. Mosaic Creation -> [Mosaic Definition, Mosaic Supply Change])

Mobile wallet as example

cryptoBeliever commented 3 years ago

myxmaster commented 3 years ago

I agree that the current display is not good. A tx with multiple mosaics looks exactly like a tx with one mosaic in the dashboard.

I suggest the following:

If a tx only contains XYM, display the amount followed by "XYM"
If a tx contains no XYM but one non-native mosaic, display the amount followed by the mosaic icon.
If a tx contains no XYM but multiple non-native mosaics, just display an icon indicating there a multiple mosaics. Example:
If a tx contains XYM and one or more non-native mosaics, display the XYM amount followed by "XYM" and the mosaic+ icon

When hovering over the mosaic+ icon, a tooltip should display all mosaics with their amounts.

cryptoBeliever commented 3 years ago

@bassemmagdy what should be changed in this issue? As I understand PR aggregates:

cryptoBeliever commented 3 years ago

@bassemmagdy

transaction 1:

cryptoBeliever commented 3 years ago

@bassemmagdy one small problem with preview when the transaction is first one then layer is cut.

cryptoBeliever commented 3 years ago

@bassemmagdy 1) on branch sprint fixes I don't see a mosaics icon. 2) is this issue fixed https://github.com/nemgrouplimited/symbol-desktop-wallet/issues/1090#issuecomment-860182758 ?

OlegMakarenko commented 3 years ago

@bassemmagdy Can we use the same icons with the Mobile Wallet for the consistency?

cryptoBeliever commented 3 years ago

Works fine. Already merged into main. Closed.