fix encrypting messages in transfer transactions

symbol / mobile-wallet

Symbol Mobile Wallet

Apache License 2.0

8 stars 14 forks source link

fix encrypting messages in transfer transactions #237

Closed bassemmagdy closed 2 years ago

bassemmagdy commented 2 years ago

fix #236
fix #234
fix #239

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 7b4f5361e6380a566b56ec41c14b00ca1293e91a into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

new alerts:

1 for Potentially inconsistent state update

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging b576c2b614f20d0c90d3447ad30208c989a00435 into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

new alerts:

1 for Potentially inconsistent state update

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 3 when merging c65f25a83cc01a3ce21b174b9e904324bb5572c1 into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

3 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request fixes 5 alerts when merging a6192dfbaf8bc79440508528d04aa9e7b4119b6c into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

fixed alerts:

5 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request fixes 5 alerts when merging 1061874a4fc15820c1f06e760f844b5c2d92d760 into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

fixed alerts:

5 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request fixes 5 alerts when merging 87b81b6ae86c55e89ae0933a0c70dedf6efe8c6c into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

fixed alerts:

5 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request fixes 5 alerts when merging 42332d554a6d67012fd197d44a365c8c66e4d664 into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

fixed alerts:

5 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request fixes 5 alerts when merging a351ee901bd56eb8a2df42e549513a7cedc58624 into 834dd0f5c68bd401dae567a75f48f16d2e8a7dfe - view on LGTM.com

fixed alerts:

5 for Unused variable, import, function or class

cryptoBeliever commented 2 years ago

All problems fixed :+1:

cryptoBeliever commented 2 years ago

@bassemmagdy as I understand this PR fixes some problems in dev branch related with multisig multilevel and it has to be merged before we will release?

bassemmagdy commented 2 years ago

@cryptoBeliever yes it needs to be merged before release.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

lgtm-com[bot] commented 2 years ago

This pull request fixes 2 alerts when merging 2de9bbd3bf7664f695ee2d38e9fa7a362b340e83 into c03c56fc88f34eadd6e16b15838cbfb8f92ed30a - view on LGTM.com

fixed alerts:

2 for Unused variable, import, function or class