symbol / mobile-wallet

Symbol Mobile Wallet
Apache License 2.0
8 stars 14 forks source link

fix: handle selected node down when application start. #258

Closed AnthonyLaw closed 3 years ago

AnthonyLaw commented 3 years ago

The application crash was caused by the selected node being unreachable.

To resolve this, we will verify the selected node status, if the node is unreachable, it will be randomly assigned the new node from the node list.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

yilmazbahadir commented 3 years ago

Is this fix covering the case when the user passed the login page but after that node goes offline/unreachable? So ideally when a call to the node fails due to node unreachable we should fire an event to trigger a different node selection.