Closed OlegMakarenko closed 2 years ago
This pull request fixes 4 alerts when merging e1e932cdb51c128d9ab2c4e70f8cbc6a377d7187 into 4e999dff1bd04a90912f1ec7d8c797bb4cd3e096 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging b63a4487482af548362e3df151fde047a4b960db into 4e999dff1bd04a90912f1ec7d8c797bb4cd3e096 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging e5e839614618c6877bff3ca6243335f04fdb2897 into 4e999dff1bd04a90912f1ec7d8c797bb4cd3e096 - view on LGTM.com
fixed alerts:
@cryptoBeliever
For unlink and link key is the same icon. We should use the strike-through key icon for UNLINK?
Added new icon and 'link' caption to the transaction type.
For non-aggregate transactions for Unconfirmed there is a date presented instead "Unconfirmed" label.
Fixed.
I think it would be very helpful to present some icon that is telling if the row is an outgoing or incoming transaction.
We have different icons for incoming and outgoing transfer tx, or do you mean something different?
This pull request fixes 4 alerts when merging 8ef7e29d182da515c7d95291dac2c8cd94227f8e into 4e999dff1bd04a90912f1ec7d8c797bb4cd3e096 - view on LGTM.com
fixed alerts:
This pull request fixes 4 alerts when merging 5f416ffe6f953a4471f4b12059bac0c9aa347d6d into 4e999dff1bd04a90912f1ec7d8c797bb4cd3e096 - view on LGTM.com
fixed alerts:
@OlegMakarenko
For unlink and link key is the same icon. We should use the strike-through key icon for UNLINK?
Added new icon and 'link' caption to the transaction type.
Thank you. New icon is presented now :+1:
For non-aggregate transactions for Unconfirmed there is a date presented instead "Unconfirmed" label.
Works correctly :+1:
I think it would be very helpful to present some icon that is telling if the row is an outgoing or incoming transaction.
We have different icons for incoming and outgoing transfer tx, or do you mean something different?
Yes, please ignore this. I thought about other than transfer transaction types but it doesn't make much sense.
This pull request fixes 4 alerts when merging f366527919caa0d9083cbb0b2d988c2c5387aa48 into 4e999dff1bd04a90912f1ec7d8c797bb4cd3e096 - view on LGTM.com
fixed alerts:
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
8.4% Duplication
This pull request fixes 4 alerts when merging 1ef1e560f8916e309e98005d04ef8acdcd54a8cf into 4e999dff1bd04a90912f1ec7d8c797bb4cd3e096 - view on LGTM.com
fixed alerts:
What the current behaviour is
Why this is an issue
What's the fix