symbol / mobile-wallet

Symbol Mobile Wallet
Apache License 2.0
8 stars 14 forks source link

[WIP] [wallet/mobile] feat: add new Aggregate Bonded cosignature UI flow #327

Open OlegMakarenko opened 2 years ago

OlegMakarenko commented 2 years ago

Temporary branch which contains both changes Address Book and Cosign Form: https://github.com/symbol/mobile-wallet/tree/address-book-bonded-merged

cryptoBeliever commented 2 years ago

@OlegMakarenko when I'm signing on mobile transaction announced by the cosigner from the desktop wallet I got an error like this (on branch address-book-bonded-merged, on address-book-bonded-2 it works):

image

OlegMakarenko commented 2 years ago

@cryptoBeliever can you please pull latest changes?

cryptoBeliever commented 2 years ago

@OlegMakarenko thank you. It's fixed now. What I noticed regarding signing flow:

  1. Transaction sent by account that is in multisig relation with our account:
    • block sender should be not available (desktop version screenshot to compare)
    • Unknown transaction awaiting signature. should be replaced by Please carefully review all amounts and recipient addresses, as transactions are not reversible.

mobile: image desktop: image

  1. Transaction sent by account that is not in multisig relation with our account:
    • I would replace "Unknown transaction awaiting signature." with something else.
    • In the desktop wallet, we don't have "Add to whitelist" shortcut (next view). Have you added it on purpose?
    • I would add a "Learn more about common hacks and scams" link

mobile: image

desktop: image

  1. When we have a "trusted" (whitelisted) transaction and when we click "Sign" we are signing without further notification if:
    • we don't have pin enabled
    • we have face id enabled (it's automatically accepted)

image