Closed AnthonyLaw closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.99%. Comparing base (
0bc06c9
) to head (2a8a491
). Report is 249 commits behind head on snap/symbol.
Looks good, but a couple of questions
- how does the user know what fee values are slow, average, and fast?
- Can the user set a custom fee?
Looks good, but a couple of questions
- how does the user know what fee values are slow, average, and fast?
- Can the user set a custom fee?
- I was thinking of implementing fees (tx size * fee multiplier) in this screen, which means I must create and prepare transactions in the front end, which doesn't look good (because I want it to implement prepare transactions in the backend)
- does it make sense we just showing fee multiplier and the fees will be displayed in the last confirmation screen?
- Nope, but I can add it in the future.
- yea, that might work but I would verify with @0x6861746366574 tbh, not sure if these are needed since most tx will get committed in the next block
What was the issue?
What's the fix?
Preview