search

symbol / product

3 stars 4 forks source link

[snap/backend]: bug fix filter account private key and network #1087

Closed AnthonyLaw closed 1 month ago

AnthonyLaw commented 2 months ago

What was the issue?

What's the fix?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.45%. Comparing base (2a255ac) to head (a3ded95). Report is 9 commits behind head on snap/symbol.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/symbol/product/pull/1087/graphs/tree.svg?width=650&height=150&src=pr&token=1vOsAmllcX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol)](https://app.codecov.io/gh/symbol/product/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol) ```diff @@ Coverage Diff @@ ## snap/symbol #1087 +/- ## =============================================== + Coverage 98.80% 99.45% +0.64% =============================================== Files 43 12 -31 Lines 2592 365 -2227 Branches 333 67 -266 =============================================== - Hits 2561 363 -2198 + Misses 31 2 -29 ``` | [Flag](https://app.codecov.io/gh/symbol/product/pull/1087/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol) | Coverage Δ | | |---|---|---| | [snap-backend](https://app.codecov.io/gh/symbol/product/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol) | `99.45% <100.00%> (+<0.01%)` | :arrow_up: | | [snap-frontend](https://app.codecov.io/gh/symbol/product/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/symbol/product/pull/1087?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol) | Coverage Δ | | |---|---|---| | [snap/backend/src/utils/accountUtils.js](https://app.codecov.io/gh/symbol/product/pull/1087?src=pr&el=tree&filepath=snap%2Fbackend%2Fsrc%2Futils%2FaccountUtils.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol#diff-c25hcC9iYWNrZW5kL3NyYy91dGlscy9hY2NvdW50VXRpbHMuanM=) | `99.19% <100.00%> (+0.01%)` | :arrow_up: | ... and [31 files with indirect coverage changes](https://app.codecov.io/gh/symbol/product/pull/1087/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=symbol)