search

symbol / product

3 stars 4 forks source link

About metal decode. #1090

Closed 0x070696E65 closed 1 month ago

0x070696E65 commented 1 month ago

If I write the metal config in rest.json, it works fine, but if I change the state with upgrade, it is removed from rest.json.

Is it possible to describe it in override.ini so that it is not deleted when upgrading?

Jaguar0625 commented 1 month ago

currently, there is --metadata argument that allows user to specify contents of rest.config!nodeMetadata only.

i propose to deprecate this options and replace it with --rest-overrides, which will allow user to override (and add) any and all settings in the generated rest.config.

please see PoC in commit 86e2418

let us know if this will be acceptable to you 🙏

0x070696E65 commented 1 month ago

I think its a good suggestion.

I understand that all override settings related to REST can be specified with that option.

I guess there are a certain number of node administrators who forget to put that option on when upgrading (and had set it once in the past), but we don't need to care about.

Jaguar0625 commented 1 month ago

Added in cc6270b