search

symbol / symbol-cli

Command-line tool for Symbol
https://docs.symbolplatform.com/cli.html
Apache License 2.0
36 stars 24 forks source link

Add test to command tables #193

Open dgarcia360 opened 4 years ago

dgarcia360 commented 4 years ago

Command tables do not have unit tests. To solve this issue, we can move existent tables to a new views folder, and implement unit tests for every table.

decentraliser commented 4 years ago

Do you want to add more tests to tables? Such as signed transactions, or edge cases (no mosaics, etc)?

IMO it is already OK like that

dgarcia360 commented 4 years ago

I would like to add tests to tables such as: https://github.com/nemtech/nem2-cli/blob/master/src/commands/metadata/account.ts#L34-L59 It might make sense to move them under the views folder as well.