symbol / symbol-hd-wallets

Hierarchical-deterministic wallets library for Symbol
BSD 2-Clause "Simplified" License
11 stars 16 forks source link

Random keywords are created duplicate words in mnemonic phrase. #18

Open AnthonyLaw opened 4 years ago

AnthonyLaw commented 4 years ago

image

decentraliser commented 4 years ago

This is a normal behaviour, the probability is around 16% IIRC

On Wed, Feb 26, 2020, 15:39 Anthony Law notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/5649156/75322621-151d0a80-58ae-11ea-955a-71db979bb9f9.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nemfoundation/nem2-hd-wallets/issues/18?email_source=notifications&email_token=AIWPBP5WZGMMLV7YRGEDCZDREYMDXA5CNFSM4K36ZK5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQKW5LQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWPBP6XTRKTG6BGANA4QSLREYMDXANCNFSM4K36ZK5A .

AnthonyLaw commented 4 years ago

But i can't click the same keywords twice in the block.

decentraliser commented 4 years ago

Ah ok, that's a wallet issue, will fix it! Thanks

On Wed, Feb 26, 2020, 15:43 Anthony Law notifications@github.com wrote:

because i can't click the same keywords twice in the block.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nemfoundation/nem2-hd-wallets/issues/18?email_source=notifications&email_token=AIWPBPYVBIWI4ZOP3JBGV5LREYMTTA5CNFSM4K36ZK5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM7EWAY#issuecomment-591284995, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWPBP5CSXXGK3Y4PQWWEVTREYMTTANCNFSM4K36ZK5A .

decentraliser commented 4 years ago

solved on the wallet side

AnthonyLaw commented 4 years ago

thanks man, will close the issue.

evias commented 4 years ago

didn't we agree that symbol-hd-wallets will also implement a fix for this as ultimately it is wrong to generate mnemonics with duplicate words