search

symbol / symbol-hd-wallets

Hierarchical-deterministic wallets library for Symbol
BSD 2-Clause "Simplified" License
11 stars 16 forks source link

I think Usage sample should use 4343 instead of 43 #34

Closed xembook closed 3 years ago

xembook commented 4 years ago

for example

https://github.com/nemtech/symbol-hd-wallets/blob/main/README.md#generating-a-hd-wallet-catapult-mijin-and-mijintest-compatible

const childAccount = wallet.getChildAccount('m/44\'/43\'/0\'/0\'/0\'', NetworkType.MIJIN_TEST);

I think this is

const childAccount = wallet.getChildAccount('m/44\'/4343\'/0\'/0\'/0\'', NetworkType.MIJIN_TEST);

thanks!

xembook commented 3 years ago

how about this?

xembook commented 3 years ago

this pull request closed.

rg911 commented 3 years ago

Yeah, we have another pr pending on this, also the desktop wallet will get them in another pr,