symflower / vmutils-bin

This repository contains packages for Homebrew and Chocolatey to install parts of the vmutil package from Victoria Metrics based on the binary releases.
https://symflower.com
MIT License
3 stars 1 forks source link

Put all versions in common file(s) instead of repeating them #3

Closed zimmski closed 1 year ago

zimmski commented 1 year ago

E.g. we have Choco/vmagent/tools/chocolateyinstall.ps1 and Formula/vmagent.rb where we use the same VMAgent version. Having the same version everywhere is usually fine but it is a common place for error when they get out of sync.

This issue should move all versions into either a common "package.json" file and then reuse the versions from there, or into conf/version/${identifier}.version files, and then use those versions in all places. This leads to having all versions/hashes/packaging-meta/... in one place instead of multiple.

Munsio commented 1 year ago

My ideal workflow would be a config file for dependabot or renovate. To automatically update the versions inside the files when a new release was tagged by victoria metrics which creates a PR on this repo.

Why: Chocolatey:

With one of the bots creating a PR we could use a Github Action to update the versions and additional parts we need in the same PR too. So everything inside this repo is self contained and mostly maintenance free.

zimmski commented 1 year ago

Fine with me, but we do not need that for our internal work at the moment. Should be an outside contribution.