lsmith77
commented
10 years ago | Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | https://github.com/symfony-cmf/Routing/pull/108 |
| License | MIT |
| Doc PR | n/a |
Closed lsmith77 closed 10 years ago
lsmith77
commented
10 years ago | Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | https://github.com/symfony-cmf/Routing/pull/108 |
| License | MIT |
| Doc PR | n/a |
lsmith77
commented
10 years ago I guess if @dbu and @dawehner are ok with this PR .. I can squash it all together into a single commit
dawehner
commented
10 years ago :ship:
dbu
commented
10 years ago great, thanks a lot!
can you add a little bit to https://github.com/symfony-cmf/symfony-cmf-docs/blob/dev/components/routing/dynamic.rst ?
i don't see where this collection is used now, or how it would be usable without overwriting DynamicRouter::getRouteCollection