search

symfony-cmf / Routing

Routing component building on the Symfony Routing component
Other
289 stars 70 forks source link

DevKit updates #232

Closed ElectricMaxxx closed 2 years ago

ElectricMaxxx commented 5 years ago

Let's start it here also

ToDo:

dbu commented 5 years ago

lets discuss things in https://github.com/symfony-cmf/routing-bundle/pull/434#pullrequestreview-197406052 and then update this once the questions have been decided.

ElectricMaxxx commented 5 years ago

I opened: https://github.com/symfony/symfony/issues/30147 as i do not understand the issue in the test. From my POV the regex is cutted for no reason.

ElectricMaxxx commented 5 years ago

mhhh ... where did i introduce the year again?

dbu commented 5 years ago

in the styleci config. i guess we missed to remove it in this one and did not notice when it wanted to add it back. i edited the styleci config now, years should be gone for good now.

or rather: we never removed it. git blame finds me this as the source for the years: https://github.com/symfony-cmf/Routing/commit/73ece46f9d4f53cd910f5670f28e14115f86863a

ElectricMaxxx commented 5 years ago

@dbu something to add here?

ElectricMaxxx commented 5 years ago

So i removed the file, will do same for the other packages. then i will merge it.