search

symfony-cmf / Routing

Routing component building on the Symfony Routing component
Other
289 stars 70 forks source link

fix passing route object parameter to generator #254

Closed gseidel closed 4 years ago

gseidel commented 4 years ago
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

If the route is fetched over a relation from the database, it could be, that the route is still a proxy object (For lazy loading). If a url is generated with a proxy route object, then symfony will generate a string like /path?_route_object%5B__isInitialized__%5D=1, because http_build_query also accept objects and generate a value if the object has a public property.

I think the parameter RouteObjectInterface::ROUTE_OBJECT is not necessary to pass it doGenerate. So it should be unset if exists.

dbu commented 4 years ago

i updated the changelog and tagged 2.3.2 with this.

gseidel commented 4 years ago

Thanks a lot @dbu