symfony-cmf / Routing

Routing component building on the Symfony Routing component
Other
289 stars 70 forks source link

Add $priority argument to ChainRouteCollection::add() #256

Closed andypost closed 4 years ago

andypost commented 4 years ago

Since symfony/routing 5.1.0 https://github.com/symfony/routing/commit/4361dad278230d98f1beff5d0ef9478ec1790ea9 route collection's add method needs extra (3rd) argument

Ref https://github.com/symfony/symfony/pull/35608

Q A
Branch? "master"
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any
dbu commented 4 years ago

thanks! i fixed master branch to have styleci fixed - can you please rebase on master to see if the tests are green?

andypost commented 4 years ago

Rebased and fixed code-style for new argument

dbu commented 4 years ago

thanks!