symfony-cmf / Routing

Routing component building on the Symfony Routing component
Other
288 stars 69 forks source link

Prepare major release and allow symfony 6 #269

Closed acrobat closed 2 years ago

acrobat commented 2 years ago
Q A
Branch? "master" for new features / the branch of the current release for fixes
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Fixed tickets
License MIT
Doc PR

This PR adds some required typehints for symfony 6 and to make this change easier I suggest to release this PR as a new major release. It's easy for project to upgrade/support the upcoming major, as only a previous deprecation is removed and all older symfony versions are still supported (+ sf6 support)

acrobat commented 2 years ago

All tests pass again, the PR is ready for review!

acrobat commented 2 years ago

I've added the necessary type checks and tests for this case

dbu commented 2 years ago

i adjusted the branch alias in composer.json.

can you add a build for php 8.1 as well? that might lead to further changes because of deprecations.