search

symfony-cmf / block-bundle

Extends the SonataBlockBundle to integrate with PHPCR ODM
https://cmf.symfony.com
20 stars 51 forks source link

Use sonata.templating service from SonataBlockBundle #282

Closed covex-nn closed 6 years ago

covex-nn commented 6 years ago
Q A
Branch? "master" for new features
Bug fix? no
New feature? yes?
BC breaks? no
Deprecations? no
Fixed tickets
License MIT
Doc PR

A templating service can be used only after manual configuration of symfony/framework-bundle, so if another bundle use it, then it cannot have a recipe for Symfony Flex.

To create a recipe for sonata-project/block-bundle a new service sonata.templating was created to replace templating service, see https://github.com/sonata-project/SonataBlockBundle/pull/457 for details. sonata.templating service can be used instead of templating without activating Templating Component in config/packages/framework.yaml. New service supports both template path notations (templating 'bundle:section:template.format.engine' ang twig namespacing syntax)

All Sonata bundles, that use Templating Component already use sonata.templating service in current stable branches. Also, SonataBlock will use twig service directly only after new major release, see https://github.com/sonata-project/SonataBlockBundle/pull/476

dbu commented 6 years ago

do you need releases of this and the content-bundle? or can you test the flex recipes with the dev-master version?

covex-nn commented 6 years ago

I currently work on recipe for SonataPageBundle, that requires symfony-cmf/routing-bundle. And i know, that you are working on 2.1 release of SymfonyCMF with Symfony4 support. So i just searched for a problems , i could help with, to make your release a little closer =) And i will test everything with master version.