search

symfony-cmf / block-bundle

Extends the SonataBlockBundle to integrate with PHPCR ODM
https://cmf.symfony.com
20 stars 51 forks source link

Master dev kit - Prepare Release #290

Closed ElectricMaxxx closed 6 years ago

ElectricMaxxx commented 6 years ago
Q A
Branch? "master" for new features / the branch of the current release for fixes
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any
dbu commented 6 years ago

sonata cache bundle 2.5 does not exist. there is 2.4 or 3.0, so i guess 2.5 will never happen. can we use 2.4 instead?

ElectricMaxxx commented 6 years ago

@dbu we had a change there which wasn't released at that point. You rember that getObject()/getDocument() issue you solved in their listener? We need that So lets have a look if it is on some release now.

dbu commented 6 years ago

okay. so the bundle 2.4 uses the DoctrinePHPCRODMListener from the cache component. the sonata cache component has the fix since 1.1.1. (https://github.com/sonata-project/cache/blob/1.1.0/src/Invalidation/DoctrinePHPCRODMListener.php vs https://github.com/sonata-project/cache/blob/1.1.1/src/Invalidation/DoctrinePHPCRODMListener.php)

i think if we change sonata cache-bundle to ^2.4 we should be fine. we could add a conflict with sonata/cache: < 1.1.1 if we get a lowest version build failure.