symfony-cmf / block-bundle

Extends the SonataBlockBundle to integrate with PHPCR ODM
https://cmf.symfony.com
20 stars 51 forks source link

DevKit updates for master branch #291

Closed ElectricMaxxx closed 5 years ago

dbu commented 6 years ago

did you give up on the installation test?

ElectricMaxxx commented 6 years ago

@dbu yes, atm it gives us less value and can confuse. At the end i would like to have one integration test (into an app equal to sandbox) of each package on one matrix item. Doing it that way we will see earlier, when something fails.

dbu commented 6 years ago

okay, we can do it that way.

i found it appealing that we would see problems right away on the specific repository when a pull request e.g. accidentally introduces a dependency on another library instead of either adding it to the composer requirements (and not dev-require) or handling the absence of the library gracefully.

but its your call, if the separate setup is easier to do, feel free to drop this from here. we never really used that check yet, so we are not losing anything.