search

symfony-cmf / cmf-sandbox

Base project for trying CMF components integration
http://cmf.symfony.com
Other
367 stars 140 forks source link

Make build run again in fix_master branch #398

Closed SenseException closed 6 years ago

SenseException commented 6 years ago

This PR is about a suggestion for the described problem in #397, where a travis-ci builds just stop. This PR is not about making the tests go green, but to make the build run till the end again.

ElectricMaxxx commented 6 years ago

yea nice, now we do see the issue :-) cool.

dbu commented 6 years ago

thanks @SenseException !

can you try to fix the styleci issues please?

looks like sonata cache expects a method getDocument to exist on the PreUpdateEventArgs of phpcr-odm. i created https://github.com/sonata-project/cache/pull/103 - i think that sonata cache invalidator never worked.

on our end, i think we should not be running any active sonata cache invalidation. is it coming from sonata admin?

SenseException commented 6 years ago

can you try to fix the styleci issues please?

Done

ElectricMaxxx commented 6 years ago

I will merge this one into master at all, as it makes the test better.