search

symfony-cmf / content-bundle

Provides some basic document classes and controllers for modeling content
https://cmf.symfony.com
19 stars 32 forks source link

Master dev kit #180

Closed ElectricMaxxx closed 6 years ago

ElectricMaxxx commented 6 years ago

Remove all deprecation warnings and other style stuff in generated files.

ElectricMaxxx commented 6 years ago

@dbu i rearanged the testing app structure, if you like it i would do it in the other bundles also. from my POV it looks cleaner now.

dbu commented 6 years ago

i would prefer to keep the non php class files and application in tests/Resources and just move the Kernel that is a regular php class to Fixtures/App. but if you prefer it over here i don't really mind that much, works too.

ElectricMaxxx commented 6 years ago

Having that Folder Structure the App/ folder looks almost like a app in the new folder style. Having all the files in Resources\ confused me a lot the last years. Now we have Fixture with some fixtures and a fixture App in a dedicated namespace

ElectricMaxxx commented 6 years ago

mh i do not get ^2.0@dev of phpcr-bundle :-(

dbu commented 6 years ago

looks not too bad, only deprecation warnings make the build fail i think.

ElectricMaxxx commented 6 years ago

yep, and that is the problem, cause they should be gone with phpcr-bundle 2.0@dev to be compatible with symfony 4

ElectricMaxxx commented 6 years ago

yess it is green