search

symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

Support imagine runtime config in display url templating helper #143

Closed aramalipoor closed 8 years ago

aramalipoor commented 8 years ago

Useful when passing dynamic thumbnail config, e.g.:

<img src="{{

cmf_media_display_url(image, {
   imagine_filter: 'my_filter',
   imagine_runtime_config: {
      'thumbnail': {'size': [120, 60]}
   }
})

}}" />
aramalipoor commented 8 years ago

@lsmith77 I'm not sure how this failing build is related to my change?! Can you help me figure it out? :)

lsmith77 commented 8 years ago

can you rebase your PR on master?

dbu commented 8 years ago

looks like master is failing too. sorry, any chance for you to look into that failure as well @aramalipoor ?

lsmith77 commented 8 years ago

yeah .. there seems to be some regression ..

lsmith77 commented 8 years ago

in a dependency .. not caused by your change ..

dbu commented 8 years ago

i guess we could merge this without master being fixed, it looks save enough. @aramalipoor can you prepare a documentation pull request against symfony-cmf-docs, that explains how to use this? please use a versionadded construct to say this will come in version 1.3