search

symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

Fix sf3 #155

Closed blump closed 8 years ago

blump commented 8 years ago

I'm sorry for the number of commit. :( This is the second time I participate in an open source project on github , so not too used

dbu commented 8 years ago

thanks for the contribution! don't worry about the commits, we can squash them into one while merging, so all fine. i added a few things i would like to clean up, but apart from that looks ready to me.

wouterj commented 8 years ago

Looks great!

However, we've abandoned this bundle as we have a too small team to maintain many bundles. So we either need to find a new maintainer of this bundle or I'm not sure if we can merge this feature (not because this is a too big feature to maintain, but because we have to maintain the complete bundle).

dbu commented 8 years ago

ah indeed, we abandoned the bundle. but i don't see much harm in continuing to merge such things as long as we find time to review them. its not like we deprecated this bundle in favor of something else...

@blump if you use this bundle in projects, how would you feel about taking over maintenance for it? it would mean you review pull requests if any come, and try to reply to issues that are opened. and possibly also work on improving the bundle, but that is no requirement.

dbu commented 8 years ago

can you fix the imagine-bundle dependency? then i will merge and tag as 1.3.1 as there is no other changes to it and i see no harm in doing this even if we don't actively maintain the bundle anymore.

blump commented 8 years ago

@dbu I hesitated but I do not use this time in my projects ... I had some time yesterday and someone asked for a fix to use it on SF3 so I told myself I was going do it.

I'm sorry, but I have enough time to be able to seriously work on this bundle ...

dbu commented 8 years ago

tagged 1.3.1, thanks @blump

ok, no worries, just thought i'd ask... i much prefer a honest answer over an illusion of having somebody who maintains this bundle but then doesn't have the time to do it.