search

symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

ChildrenCollection of medea files fails #169

Open ElectricMaxxx opened 7 years ago

ElectricMaxxx commented 7 years ago

Adding a collection of media files (images or files) to a node/document is quite easy. The persistence works, but trying to visualize them in a collection form type with the ImageType or FileType as entity fails, as the collection is created with the nodes names as keys. Those keys, which are file names in case of medea files, fail on form name validation. with an exception like:

 Symfony\Component\Form\Exception\InvalidArgumentException: The name "IMG_4721.JPG" contains illegal characters. Names should start with a letter, digit or underscore and only contain letters, digits, numbers, underscores ("_"), hyphens ("-") and colons (":").
    at n/a
        in /var/www/prberghoff/New/vendor/symfony/symfony/src/Symfony/Component/Form/FormConfigBuilder.php line 865

    at Symfony\Component\Form\FormConfigBuilder::validateName('IMG_4721.JPG')
        in /var/www/prberghoff/New/vendor/symfony/symfony/src/Symfony/Component/Form/FormConfigBuilder.php line 193

But it would be nice to edit and persist files in a arbitrary collection without enclosing them into a document with nice names.

ElectricMaxxx commented 7 years ago

From my POV the collection for the form is created in here: ../Doctrine/ODM/PHPCR/ChildrenCollection.php:98 Maybe we should provide an extra media children collection with basenames only, but i have no clue what happens when trying to persisten them afterwards. Or we shall use an extra media collection transformer to replace the collection before that.