symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

Symfony\Cmf\Bundle\MediaBundle\Adapter\ElFinder\PhpcrDriver::$options must be protected or weaker #177

Closed stefandoorn closed 6 years ago

stefandoorn commented 6 years ago
FatalErrorException:
Compile Error: Access level to Symfony\Cmf\Bundle\MediaBundle\Adapter\ElFinder\PhpcrDriver::$options must be protected (as in class FM\ElFinderPHP\Driver\ElFinderVolumeDriver) or weaker
dbu commented 6 years ago

just a note: this bundle is currently not maintained, as stated in the readme. we don't have the capacity atm to maintain it, unfortunately.

stefandoorn commented 6 years ago

Ah, didn't see. Will see if I can submit a PR for this issue, will that be merged in that case?

dbu commented 6 years ago

i can hit merge, yes. but this has not been updated to recent php and symfony...

btw, if you want to take over maintenance, i am more than happy to give you commit rights on the repo.

stefandoorn commented 6 years ago

Hm ok, maybe not a good idea then to merge it, seems nobody is running into the issue anyway. I can't over maintenance, as I have no clue about the internals of this library, but thanks for the offer :) For now I'll make a fork to get around this issue.