search

symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

Remove incorrect xml mapping path #42

Closed EmmanuelVella closed 11 years ago

EmmanuelVella commented 11 years ago

As the Resources\config\doctrine-model directory does not exist, the realpath method returns false, causing this exception :

[Doctrine\Common\Persistence\Mapping\MappingException]                                                  
File mapping drivers must have a valid directory path, however the given path 0 seems to be incorrect!
lsmith77 commented 11 years ago

@rmsint can you have a look here?

lsmith77 commented 11 years ago

btw @EmmanuelVella see also #41

EmmanuelVella commented 11 years ago

Yes, I saw this PR and this should not be a problem as the directory is still not present, and this code remains untouched : https://github.com/symfony-cmf/MediaBundle/pull/41/files#L1R25

rmsint commented 11 years ago

Thanks for spotting this, didn't see it in the tests. We can better remove it when not used indeed. I will wait until this evening because maybe we move a metadata file to the folder in the bundle standards PR, but otherwise I am ok to merge.

Out of intrest, when does it happen? Maybe this is related to a version or library used. Atm it is mainly tested with the sandbox and jackrabbit. And the testing component uses doctrine dbal to run the tests. I expect soon that we will hookup travis and we have more configurations coverend.

EmmanuelVella commented 11 years ago

The error occured when I executed the app/console assets:install --symlink web --env=prod command.

rmsint commented 11 years ago

Thanks again

EmmanuelVella commented 11 years ago

Thanks for the merge !