[WIP] Elfinder - Githubissues

symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF

http://cmf.symfony.com/

30 stars 40 forks source link

[WIP] Elfinder #46

Closed rmsint closed 11 years ago

rmsint commented 11 years ago

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#28
License	MIT
Doc PR	https://github.com/symfony-cmf/symfony-cmf-docs/pull/251

TODO to merge

[ ] code review / cleanup
[ ] check root creating (see PHPCRDriver:: _stat)
[ ] check rename error (DocumentManager::move results in an error)
[x] add installation documentation
[x] recheck image preview with imagine thumbnail - elFinder uses the same url for full screen display
[ ] check if it is possible to return a placeholder for the url and use a filter or something when rendering content (use a dataFilter rule for ckeditor)

//cc @sjopet

rmsint commented 11 years ago

Using the imagine filter does not work as expected. When selecting an image using ckeditor the imagine_filter is also applied and the imagine url is returned. Therefore the change is undone.

Furthermore a media browser abstraction is added, maybe only for the browse url too much atm. On the other side it is consistent with the upload helper. The media browser is implemented in https://github.com/symfony-cmf/CreateBundle/pull/75 for Create and adds automatically elfinder to ckeditor if elfinder is installed.

rmsint commented 11 years ago

@helios-ag fyi, this will provide integration between the Symfony CMF and elFinder using the FMElfinderBundle. Do you have time to help us with a quick check of the driver: Adapter/ElFinder/PhpcrDriver, do you see anything faulty or missing? Maybe you find something we missed.

dbu commented 11 years ago

@helios-ag oh indeed that would be helpful. and maybe you can also help us with the imagine question above: i guess the question boils down to if there is a way to have a separate preview image url and display url. and as a bonus, if there can be some way to select from a list of variants of the image (imagine allows us to define named filters that can scale or otherwise process the image when downloading. while still having only one version of the uploaded image so different variants can be used in different places)

rmsint commented 11 years ago

Rebased to include merged https://github.com/symfony-cmf/MediaBundle/pull/48

rmsint commented 11 years ago

Not sure if we want to fix the last comments (after https://github.com/symfony-cmf/MediaBundle/pull/46#commits-pushed-1ddd159) before merge. If so, someone has to take over, I will be packing my bags for holiday.

lsmith77 commented 11 years ago

i have created followup tickets