search

symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

[WIP] Refactoring for QbV2 #60

Closed rmsint closed 11 years ago

rmsint commented 11 years ago

/cc @dantleech Are the changes correct like this?

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? n/a
Fixed tickets n/a
License MIT
Doc PR n/a
dantleech commented 11 years ago

btw, see https://github.com/doctrine/phpcr-odm-documentation/pull/33 for a very WIP reference.

rmsint commented 11 years ago

@dantleech, thx updated the code. Used the WIP reference to create the PR, in there it is still descendantDocument instead of descendant.

dbu commented 11 years ago

travis complains about a parse error... can you investigate please?

lsmith77 commented 11 years ago

i have fixed the parse error

lsmith77 commented 11 years ago

btw .. do we have tests covering this functionality?

rmsint commented 11 years ago

No not yet, they should be added.

dbu commented 11 years ago

so, good to merge or is there a reason to wait?

lsmith77 commented 11 years ago

we should have a test

lsmith77 commented 11 years ago

@rmsint do you have time to add a test by tomorrow so that we can include this PR into the next release with confidence?

rmsint commented 11 years ago

I can try to do this as of 25-9 end of the morning, then I have access to my computer again. Currently traveling without.

lsmith77 commented 11 years ago

i have created a follow up ticket for the missing test

rmsint commented 11 years ago

thx, I got delayed while traveling and I am to tired to produce anything useful today.