search

symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

elfinder: remove root creation from _stat method #68

Closed rmsint closed 11 years ago

rmsint commented 11 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #53
License MIT
Doc PR N/A
rmsint commented 11 years ago

In the documentation of the MediaBundle is described, as part of the installation, to run the repository initializer to create the root. If the user forgets this, elFinder will return a vague error. Probably later we can improve the error message elFinder returns.

dbu commented 11 years ago

is there still an issue with detecting if a path exists as described in #53 or was this just an edge case?

rmsint commented 11 years ago

Ah yes, that a user configured a subpath for elFinder, fe. /cms/media/videos/. Then the user must make sure to have created that subpath before.

dbu commented 11 years ago

i mean more in general: is #53 really fixed? that is, does the stat() method now work correctly or does it just matter less because we do not notice the error as much anymore?

rmsint commented 11 years ago

yes, the stat() works as it should be. Although imho we should be able to tell a user what went wrong instead of only returning false, but this is elFinder in general.