symfony-cmf / media-bundle

UNMAINTAINED - Minimalistic interfaces to handle media in the context of the CMF
http://cmf.symfony.com/
30 stars 40 forks source link

cleanup xml config schema #86

Closed dbu closed 10 years ago

dbu commented 10 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -
lsmith77 commented 10 years ago

@WouterJ ok to merge?

wouterj commented 10 years ago

@lsmith77 I don't have push access to this repo (only this one...). Can I please get that, so I can fix this PR?

lsmith77 commented 10 years ago

seems like something s broken now.

dbu commented 10 years ago

PHP Fatal error: Call to undefined method Symfony\Component\Config\Definition\Builder\NodeBuilder::prototype() in /home/travis/build/symfony-cmf/MediaBundle/DependencyInjection/Configuration.php on line 101

@WouterJ is that your change or was it me?

wouterj commented 10 years ago

@dbu I already fixed it :)

wouterj commented 10 years ago

it's ready! Merge it if you agree with my config change.

dbu commented 10 years ago

hooray! thanks for the help, wouter.